Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AP1032] Show dead hosts as possible reason in empty report when scan finishes #3124

Merged
merged 2 commits into from
Aug 6, 2021
Merged

[AP1032] Show dead hosts as possible reason in empty report when scan finishes #3124

merged 2 commits into from
Aug 6, 2021

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Aug 6, 2021 •
edited
Loading

What:
Show possibility of dead hosts also for finished scans, not only progress < 0

Why:
The notification was not shown after scanning a dead host and was reported missing

How:

  1. Create a target with a non-existing host.
  2. Scan that target to produce an empty report.
  3. Check that the notification is listed in the Results tab in the report details.

Checklist:

  • [N/A] Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@swaterkamp swaterkamp added port-to-main Use mergifiy to port PR to master port-to-stable Use mergifiy to port PR to stable labels Aug 6, 2021
@swaterkamp swaterkamp self-assigned this Aug 6, 2021
@swaterkamp swaterkamp requested a review from a team as a code owner August 6, 2021 11:43
@codecov
Copy link

codecov bot commented Aug 6, 2021 •
edited
Loading

Codecov Report

Merging #3124 (4e7dcb4) into gsa-20.08 (1e86336) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-20.08    #3124   +/-   ##
==========================================
  Coverage      53.73%   53.74%           
==========================================
  Files           1073     1073           
  Lines          25909    25911    +2     
  Branches        7401     7402    +1     
==========================================
+ Hits           13923    13925    +2     
  Misses         10882    10882           
  Partials        1104     1104
Impacted Files Coverage Δ
gsa/src/web/pages/reports/details/emptyreport.js 95.45% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e86336...4e7dcb4. Read the comment docs.

@swaterkamp
Change condition for showing dead host possibility in empty report
5a3bb7d 
Show the message when the scan finished, not only with a progress of < 1
@swaterkamp
Update Changelog
4e7dcb4
@swaterkamp swaterkamp force-pushed the swaterkamp/deadHostEmptyReport2008 branch from 26e63dc to 4e7dcb4 Compare August 6, 2021 13:40
@sarahd93 sarahd93 merged commit c79c416 into gsa-20.08 Aug 6, 2021
@sarahd93 sarahd93 deleted the swaterkamp/deadHostEmptyReport2008 branch August 6, 2021 13:55
This was referenced Aug 6, 2021
Merged
Merged
swaterkamp added a commit that referenced this pull request Aug 6, 2021
@swaterkamp
Merge pull request #3125 from greenbone/mergify/bp/master/pr-3124
4b82714 
[AP1032] Show dead hosts as possible reason in empty report when scan finishes (backport #3124)
swaterkamp added a commit that referenced this pull request Aug 6, 2021
@swaterkamp
Merge pull request #3126 from greenbone/mergify/bp/gsa-21.04/pr-3124
40e785d 
[AP1032] Show dead hosts as possible reason in empty report when scan finishes (backport #3124)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahd93 sarahd93 sarahd93 approved these changes

Assignees

@swaterkamp swaterkamp

Labels
port-to-main Use mergifiy to port PR to master port-to-stable Use mergifiy to port PR to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swaterkamp @sarahd93